Skip to content

Interaction: alert, prompt, confirm #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 27, 2019
Merged

Interaction: alert, prompt, confirm #21

merged 10 commits into from
Oct 27, 2019

Conversation

sohag-pro
Copy link
Contributor

Here you go.

:)

@javascript-translate-bot javascript-translate-bot requested a review from a team October 22, 2019 09:38
@iliakan iliakan mentioned this pull request Oct 22, 2019
Open
jaamaalxyz
jaamaalxyz requested changes Oct 22, 2019
View reviewed changes
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@sohag-pro
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team October 23, 2019 04:17
jaamaalxyz
jaamaalxyz requested changes Oct 23, 2019
View reviewed changes
Copy link
Member

@jaamaalxyz jaamaalxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ভাই আগের রিভিউয়ে আজকের বিষয় গুলো হইত চোখে পড়ে নি। দুঃখিত আপনাকে সঠিক ভাবে গাইড করতে না পারায়। আপনার কাজ আমাদের কমিউনিটির জন্য অনেক গুরুত্তপূর্ণ। আমাদের সাথে থাকার জন্য ধন্যবাদ। এবারের ইস্যু গুলো ফিক্স করে কমিট করলে মারজ হয়ে যাবে আশা করছি।

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@sohag-pro
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team October 24, 2019 17:56
ta-riq
ta-riq suggested changes Oct 25, 2019
View reviewed changes
Copy link

@ta-riq ta-riq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we dont need to translate the texts inside code blocks. Isn't that mentioned in the rules ?

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@sohag-pro
Copy link
Contributor Author

/done

@jaamaalxyz
Copy link
Member

I think we don't need to translate the texts inside code blocks. Isn't that mentioned in the rules?

Brother @ta-riq we can change the string inside any code blocks and also we translate comments. otherwise, code blocks are not changeable. thanks for your opinions.

jaamaalxyz
jaamaalxyz approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@jaamaalxyz jaamaalxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost ok, thanks for your great work brother @shuvo575

@jaamaalxyz jaamaalxyz merged commit 0ca35bd into javascript-tutorial:master Oct 27, 2019
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

ta-riq
ta-riq reviewed Nov 7, 2019
View reviewed changes
Copy link

@ta-riq ta-riq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ta-riq ta-riq ta-riq requested changes

@jaamaalxyz jaamaalxyz jaamaalxyz approved these changes

Assignees
No one assigned
Labels
needs +1 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sohag-pro @javascript-translate-bot @jaamaalxyz @ta-riq @raikusy